-
- Downloads
feat(highlight): update default color scheme
Problem: Default color scheme is suboptimal. Solution: Start using new color scheme. Introduce new `vim` color scheme for opt-in backward compatibility. ------ Main design ideas - Be "Neovim branded". - Be minimal for 256 colors with a bit more shades for true colors. - Be accessible through high enough contrast ratios. - Be suitable for dark and light backgrounds via exchange of dark and light palettes. ------ Palettes - Have dark and light variants. Implemented through exporeted `NvimDark*` and `NvimLight*` hex colors. - Palettes have 4 shades of grey for UI elements and 6 colors (red, yellow, green, cyan, blue, magenta). - Actual values are computed procedurally in Oklch color space based on a handful of hyperparameters. - Each color has a 256 colors variant with perceptually closest color. ------ Highlight groups Use: - Grey shades for general UI according to their design. - Bold text for keywords (`Statement` highlight group). This is an important choice to increase accessibility for people with color deficiencies, as it doesn't rely on actual color. - Green for strings, `DiffAdd` (as background), `DiagnosticOk`, and some minor text UI elements. - Cyan as main syntax color, i.e. for function usage (`Function` highlight group), `DiffText`, `DiagnosticInfo`, and some minor text UI elements. - Red to generally mean high user attention, i.e. errors; in particular for `ErrorMsg`, `DiffDelete`, `DiagnosticError`. - Yellow very sparingly only with true colors to mean mild user attention, i.e. warnings. That is, `DiagnosticWarn` and `WarningMsg`. - Blue very sparingly only with true colors as `DiagnosticHint` and some additional important syntax group (like `Identifier`). - Magenta very carefully (if at all). ------ Notes - To make tests work without relatively larege updates, each one is prepended with an equivalent of the call `:colorscheme vim`. Plus some tests which spawn new Neovim instances also now use 'vim' color scheme. In some cases tests are updated to fit new default color scheme.
Showing
- runtime/colors/default.vim 5 additions, 7 deletionsruntime/colors/default.vim
- runtime/colors/vim.vim 269 additions, 0 deletionsruntime/colors/vim.vim
- runtime/doc/dev_theme.txt 103 additions, 0 deletionsruntime/doc/dev_theme.txt
- runtime/doc/news.txt 3 additions, 0 deletionsruntime/doc/news.txt
- runtime/doc/vim_diff.txt 2 additions, 0 deletionsruntime/doc/vim_diff.txt
- src/nvim/highlight_group.c 304 additions, 223 deletionssrc/nvim/highlight_group.c
- test/functional/api/highlight_spec.lua 1 addition, 1 deletiontest/functional/api/highlight_spec.lua
- test/functional/autocmd/focus_spec.lua 4 additions, 2 deletionstest/functional/autocmd/focus_spec.lua
- test/functional/core/main_spec.lua 10 additions, 9 deletionstest/functional/core/main_spec.lua
- test/functional/helpers.lua 5 additions, 0 deletionstest/functional/helpers.lua
- test/functional/terminal/api_spec.lua 1 addition, 1 deletiontest/functional/terminal/api_spec.lua
- test/functional/terminal/buffer_spec.lua 4 additions, 2 deletionstest/functional/terminal/buffer_spec.lua
- test/functional/terminal/cursor_spec.lua 337 additions, 324 deletionstest/functional/terminal/cursor_spec.lua
- test/functional/terminal/tui_spec.lua 46 additions, 21 deletionstest/functional/terminal/tui_spec.lua
- test/functional/ui/cursor_spec.lua 1 addition, 1 deletiontest/functional/ui/cursor_spec.lua
- test/functional/ui/embed_spec.lua 21 additions, 15 deletionstest/functional/ui/embed_spec.lua
- test/functional/ui/float_spec.lua 5 additions, 5 deletionstest/functional/ui/float_spec.lua
- test/functional/ui/hlstate_spec.lua 1 addition, 1 deletiontest/functional/ui/hlstate_spec.lua
- test/functional/ui/output_spec.lua 1 addition, 1 deletiontest/functional/ui/output_spec.lua
- test/functional/ui/quickfix_spec.lua 3 additions, 3 deletionstest/functional/ui/quickfix_spec.lua
Loading
Please register or sign in to comment